Skip to content

Commit

Permalink
fix!: update GoogleMLKit pods to version 6.0.0 on iOS (#179)
Browse files Browse the repository at this point in the history
* fix: update `GoogleMLKit` pods to version `6.0.0` on iOS

* revert

* chore(ios): set minimum deployment target to 16

* chiore(translation): increase deployment target

* chore(translation): set minimum deployment target to 15.5

* docs

* docs: update changeset
  • Loading branch information
robingenz authored Oct 9, 2024
1 parent 61b1ce5 commit 2901e1b
Show file tree
Hide file tree
Showing 11 changed files with 29 additions and 11 deletions.
8 changes: 8 additions & 0 deletions .changeset/brown-singers-press.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@capacitor-mlkit/barcode-scanning': patch
'@capacitor-mlkit/face-detection': patch
'@capacitor-mlkit/selfie-segmentation': patch
'@capacitor-mlkit/translation': major
---

fix(ios): update `GoogleMLKit` pods to version `6.0.0`
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/Plugin/**/*.{swift,h,m,c,cc,mm,cpp}'
s.ios.deployment_target = '13.0'
s.dependency 'Capacitor'
s.dependency 'GoogleMLKit/BarcodeScanning', '5.0.0'
s.dependency 'GoogleMLKit/BarcodeScanning', '6.0.0'
s.swift_version = '5.1'
s.static_framework = true
end
2 changes: 1 addition & 1 deletion packages/barcode-scanning/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ end

target 'Plugin' do
capacitor_pods
pod 'GoogleMLKit/BarcodeScanning', '5.0.0'
pod 'GoogleMLKit/BarcodeScanning', '6.0.0'
end

target 'PluginTests' do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/Plugin/**/*.{swift,h,m,c,cc,mm,cpp}'
s.ios.deployment_target = '13.0'
s.dependency 'Capacitor'
s.dependency 'GoogleMLKit/FaceDetection', '5.0.0'
s.dependency 'GoogleMLKit/FaceDetection', '6.0.0'
s.swift_version = '5.1'
s.static_framework = true
end
2 changes: 1 addition & 1 deletion packages/face-detection/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ end

target 'Plugin' do
capacitor_pods
pod 'GoogleMLKit/FaceDetection', '5.0.0'
pod 'GoogleMLKit/FaceDetection', '6.0.0'
end

target 'PluginTests' do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/Plugin/**/*.{swift,h,m,c,cc,mm,cpp}'
s.ios.deployment_target = '13.0'
s.dependency 'Capacitor'
s.dependency 'GoogleMLKit/SegmentationSelfie', '5.0.0'
s.dependency 'GoogleMLKit/SegmentationSelfie', '6.0.0'
s.swift_version = '5.1'
s.static_framework = true
end
2 changes: 1 addition & 1 deletion packages/selfie-segmentation/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ end

target 'Plugin' do
capacitor_pods
pod 'GoogleMLKit/SegmentationSelfie', '5.0.0'
pod 'GoogleMLKit/SegmentationSelfie', '6.0.0'
end

target 'PluginTests' do
Expand Down
2 changes: 1 addition & 1 deletion packages/translation/CapacitorMlkitTranslation.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/Plugin/**/*.{swift,h,m,c,cc,mm,cpp}'
s.ios.deployment_target = '13.0'
s.dependency 'Capacitor'
s.dependency 'GoogleMLKit/Translate', '5.0.0'
s.dependency 'GoogleMLKit/Translate', '6.0.0'
s.swift_version = '5.1'
s.static_framework = true
end
10 changes: 10 additions & 0 deletions packages/translation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ This plugin will use the following project variables (defined in your app’s `v

- `$mlkitTranslateVersion` version of `com.google.mlkit:translate` (default: `17.0.1`)

### iOS

#### Minimum Deployment Target

Make sure to set the deployment target in your `ios/App/Podfile` to at least `15.5`:

```ruby
platform :ios, '15.5'
```

## Configuration

No configuration required for this plugin.
Expand Down
4 changes: 2 additions & 2 deletions packages/translation/ios/Plugin.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Plugin/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
IPHONEOS_DEPLOYMENT_TARGET = 15.5;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks $(FRAMEWORK_SEARCH_PATHS)\n$(FRAMEWORK_SEARCH_PATHS)\n$(FRAMEWORK_SEARCH_PATHS)";
ONLY_ACTIVE_ARCH = YES;
PRODUCT_BUNDLE_IDENTIFIER = com.getcapacitor.Plugin;
Expand All @@ -547,7 +547,7 @@
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Plugin/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
IPHONEOS_DEPLOYMENT_TARGET = 15.5;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks $(FRAMEWORK_SEARCH_PATHS)";
ONLY_ACTIVE_ARCH = NO;
PRODUCT_BUNDLE_IDENTIFIER = com.getcapacitor.Plugin;
Expand Down
4 changes: 2 additions & 2 deletions packages/translation/ios/Podfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :ios, '13.0'
platform :ios, '15.5'

def capacitor_pods
# Comment the next line if you're not using Swift and don't want to use dynamic frameworks
Expand All @@ -9,7 +9,7 @@ end

target 'Plugin' do
capacitor_pods
pod 'GoogleMLKit/Translate', '5.0.0'
pod 'GoogleMLKit/Translate', '6.0.0'
end

target 'PluginTests' do
Expand Down

0 comments on commit 2901e1b

Please sign in to comment.