Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication): update Firebase Auth for Android to 22.1.2 #447

Merged
merged 4 commits into from
Oct 7, 2023

Conversation

mverdon
Copy link
Contributor

@mverdon mverdon commented Oct 6, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

This pull request updates the Firebase Authentication library for Android to 22.1.2. Using version 21 shows a message in Play Console warning the developer that the SafetyNet API will be discontinued soon:

play_console_safetynet_issue

The version 22 removed SafetyNet support for app verification during phone number authentication (see changelog here). Although it is marked as a breaking change, this does not seem to affect the functionality of this plugin. SafetyNet will be discontinued soon as mentioned in their deprecation timeline. This link also gives information on how to migrate to the new Play Integrity API.

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Please also update the version information in the packages/authentication/README.md file.

@robingenz
Copy link
Member

@mverdon Thank you for your contribution!

@robingenz robingenz merged commit f845e3c into capawesome-team:main Oct 7, 2023
@github-actions github-actions bot mentioned this pull request Oct 7, 2023
@gelinger777
Copy link

@robingenz @mverdon could you share short instruction how to make this work? I have removed the authentication plugin reinstalled it then did cap sync and didn't worked. Any ideas what extra steps needed ?

@robingenz
Copy link
Member

@gelinger777 You just need to update to the latest version:

npm i @capacitor-firebase/authentication@latest

You can also set the sdk version manually. Just set the$firebaseAuthVersion project variable (defined in your app’s variables.gradle file). If this does not work, please create a bug report with a minimal, reproducible example.

@gelinger777
Copy link

@gelinger777 You just need to update to the latest version:

npm i @capacitor-firebase/authentication@latest

You can also set the sdk version manually. Just set the$firebaseAuthVersion project variable (defined in your app’s variables.gradle file). If this does not work, please create a bug report with a minimal, reproducible example.

Just saw this. Will try now. Thank you

@gelinger777
Copy link

@robingenz in Ionic Capacitor I don't see any $firebaseAuthVersion variable in variables.gradle... Do we need it really? Als o is this only step needed or something else too?

@robingenz
Copy link
Member

@robingenz in Ionic Capacitor I don't see any $firebaseAuthVersion variable in variables.gradle... Do we need it really? Als o is this only step needed or something else too?

No, it's optional. You can set it if you want to force the version.

@gelinger777
Copy link

@robingenz what confuses me is I have checked and in google cloud project the Play Integrity API is enabled

image

So when I search for example how to enable it in debug build article referenced speaks about App Check

https://support.google.com/googleplay/android-developer/thread/204471063/how-to-make-play-integrity-work-with-debug-key?hl=en

https://firebase.google.com/docs/app-check/android/debug-provider

So is App Check needed for Play Integrity checks?

@robingenz
Copy link
Member

@gelinger777 I still don't know exactly what the problem is. As i said, please create a detailed bug report with a minimal, reproducible example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants