-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authentication): update Firebase Auth for Android to 22.1.2 #447
feat(authentication): update Firebase Auth for Android to 22.1.2 #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Please also update the version information in the packages/authentication/README.md
file.
@mverdon Thank you for your contribution! |
@robingenz @mverdon could you share short instruction how to make this work? I have removed the authentication plugin reinstalled it then did cap sync and didn't worked. Any ideas what extra steps needed ? |
@gelinger777 You just need to update to the latest version:
You can also set the sdk version manually. Just set the |
Just saw this. Will try now. Thank you |
@robingenz in Ionic Capacitor I don't see any $firebaseAuthVersion variable in variables.gradle... Do we need it really? Als o is this only step needed or something else too? |
No, it's optional. You can set it if you want to force the version. |
@robingenz what confuses me is I have checked and in google cloud project the Play Integrity API is enabled So when I search for example how to enable it in debug build article referenced speaks about App Check https://firebase.google.com/docs/app-check/android/debug-provider So is App Check needed for Play Integrity checks? |
@gelinger777 I still don't know exactly what the problem is. As i said, please create a detailed bug report with a minimal, reproducible example. |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset
).This pull request updates the Firebase Authentication library for Android to 22.1.2. Using version 21 shows a message in Play Console warning the developer that the SafetyNet API will be discontinued soon:
The version 22 removed SafetyNet support for app verification during phone number authentication (see changelog here). Although it is marked as a breaking change, this does not seem to affect the functionality of this plugin. SafetyNet will be discontinued soon as mentioned in their deprecation timeline. This link also gives information on how to migrate to the new Play Integrity API.