Add Helm template storage backend logic #685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
RUNNER_CONTEXT_PATH=cmd/helm-runner/example-input/context.yaml \ RUNNER_ARGS_PATH=cmd/helm-runner/example-input/install-args.yaml \ RUNNER_LOGGER_DEV_MODE=true \ RUNNER_COMMAND="install" \ go run cmd/helm-runner/main.go
cap.type.helm.template.storage:0.1.0
Unfortunately, in my case, it's quite slow. Probably we will need to debug it further. Currently, for my setup to work properly, it requires 1CPU.
The general problem is that the PostgreSQL has as a dependency “common” chart (small size). We need to download it (in general deps charts) as it won't be available by default. The LocateChart method from Helm project, that is able to download this chart, starts with downloading an index file which in case of Bitnami has >3MB. This needs to be decoded and as a result it requires a much higher CPU limit.
You could say, that this is a special case, but unfortunately the PostgreSQL is quite often used in our examples. It needs to work properly.
Additionally, Helm methods don't support context, so we are not able to cancel any ongoing operation even if user cancelled the request and no one will wait for the response.
Related issue(s)
Fix #672