Skip to content

Commit

Permalink
🦄 refactor: Revise link arguments for macos
Browse files Browse the repository at this point in the history
  • Loading branch information
caoccao committed Nov 14, 2024
1 parent 731515d commit f1b72ac
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR CMAKE_SYSTEM_NAME STREQUAL "Android
# https://github.com/abseil/abseil-cpp/blob/master/CMake/README.md
add_subdirectory(${V8_DIR}/third_party/abseil-cpp ${V8_RELEASE_DIR}/third_party/abseil-cpp)
target_link_libraries(Javet PUBLIC -lc++ absl::base absl::time)
target_link_libraries(JavetStatic PUBLIC -lc++ absl::base absl::time)
endif()
if(DEFINED NODE_DIR)
list(APPEND includeDirs
Expand All @@ -327,9 +328,8 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR CMAKE_SYSTEM_NAME STREQUAL "Android
# This is a patch build.
# https://github.com/abseil/abseil-cpp/blob/master/CMake/README.md
add_subdirectory(${NODE_DIR}/deps/v8/third_party/abseil-cpp ${NODE_DIR}/out.${OUT_DIR_SUFFIX}/Release/third_party/abseil-cpp)
target_link_libraries(Javet PUBLIC absl::base absl::crc32c absl::time)
target_link_libraries(Javet PUBLIC v8_init)
target_link_libraries(JavetStatic PUBLIC v8_init)
target_link_libraries(Javet PUBLIC v8_init absl::base absl::crc32c absl::time)
target_link_libraries(JavetStatic PUBLIC v8_init absl::base absl::crc32c absl::time)
endif()
# https://caoccao.blogspot.com/2021/08/jni-symbol-conflicts-in-mac-os.html
target_link_libraries(Javet PUBLIC -exported_symbols_list ${CMAKE_SOURCE_DIR}/jni/exported_symbols_list.txt)
Expand Down

0 comments on commit f1b72ac

Please sign in to comment.