Skip to content

Commit

Permalink
🐳 chore: Upgrade V8 to v12.9.202.18
Browse files Browse the repository at this point in the history
  • Loading branch information
caoccao committed Sep 15, 2024
1 parent 7829a7c commit 782d4ea
Show file tree
Hide file tree
Showing 19 changed files with 61 additions and 50 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/android_v8_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
workflow_dispatch:

env:
JAVET_V8_VERSION: 12.8.374.17
JAVET_V8_VERSION: 12.9.202.18
JAVET_VERSION: 3.1.8
ROOT: /home/runner/work/Javet

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linux_build_artifact.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ env:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_REPO_JAVET: ${{ secrets.DOCKERHUB_REPO_JAVET }}
JAVET_NODE_VERSION: 20.17.0
JAVET_V8_VERSION: 12.8.374.17
JAVET_V8_VERSION: 12.9.202.18
JAVET_VERSION: 3.1.8

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linux_build_node_v8_image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_REPO_JAVET: ${{ secrets.DOCKERHUB_REPO_JAVET }}
JAVET_NODE_VERSION: 20.17.0
JAVET_V8_VERSION: 12.8.374.17
JAVET_V8_VERSION: 12.9.202.18
JAVET_VERSION: 3.1.8

# if we skip a job using a job level `if` condition, then any dependent jobs also don't run.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linux_x86_64_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
JAVET_NODE_VERSION: 20.17.0
JAVET_V8_VERSION: 12.8.374.17
JAVET_V8_VERSION: 12.9.202.18
JAVET_VERSION: 3.1.8
ROOT: /home/runner/work/Javet

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos_arm64_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
JAVET_NODE_VERSION: 20.17.0
JAVET_V8_VERSION: 12.8.374.17
JAVET_V8_VERSION: 12.9.202.18
JAVET_VERSION: 3.1.8
ROOT: /Users/runner/work/Javet

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos_x86_64_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
JAVET_NODE_VERSION: 20.17.0
JAVET_V8_VERSION: 12.8.374.17
JAVET_V8_VERSION: 12.9.202.18
JAVET_VERSION: 3.1.8
ROOT: /Users/runner/work/Javet

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows_x86_64_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
JAVET_NODE_VERSION: 20.17.0
JAVET_V8_VERSION: 12.8.374.17
JAVET_V8_VERSION: 12.9.202.18
JAVET_VERSION: 3.1.8
ROOT: D:\a\Javet

Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ arm ✔️ ❌ ❌ ❌
arm64 ✔️ ✔️ ✔️ ❌
=========== ======= ======= ======= =======

* Node.js ``v20.17.0`` + V8 ``v12.8.374.17``
* Node.js ``v20.17.0`` + V8 ``v12.9.202.18``
* Dynamic switch between Node.js and V8 mode
* Polyfill V8 mode with `Javenode <https://github.com/caoccao/Javenode>`_
* V8 API exposure in JVM
Expand Down
63 changes: 34 additions & 29 deletions cpp/jni/javet_jni_function.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -158,16 +158,21 @@ JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionCopyS
// Clone the scope info
#ifdef ENABLE_NODE
auto sourceScopeInfo = sourceV8InternalShared.scope_info();
#else
auto sourceScopeInfo = sourceV8InternalShared->scope_info();
#endif
auto emptyBlocklistHandle = V8InternalStringSet::New(v8InternalIsolate);
auto targetScopeInfo = *V8InternalScopeInfo::RecreateWithBlockList(
v8InternalIsolate, v8::internal::handle(sourceScopeInfo, v8InternalIsolate), emptyBlocklistHandle);
#ifdef ENABLE_NODE
targetV8InternalShared.set_raw_scope_info(targetScopeInfo);
#else
targetV8InternalShared->set_raw_scope_info(targetScopeInfo);
auto sourceScopeInfo = sourceV8InternalShared->scope_info();
const int length = (sourceScopeInfo->AllocatedSize() - V8InternalHeapObject::kHeaderSize) / v8::internal::kTaggedSize;
auto targetScopeInfo = v8InternalIsolate->factory()->NewScopeInfo(length);

This comment has been minimized.

Copy link
@caoccao

caoccao Sep 15, 2024

Author Owner

There might be memory leak. Further check is required.

This comment has been minimized.

Copy link
@caoccao

caoccao Sep 16, 2024

Author Owner

There is no memory leak because the source and target scope infos are managed by the handle scope automatically.

v8InternalIsolate->heap()->CopyRange(
*targetScopeInfo,
targetScopeInfo->data_start(),
sourceScopeInfo->data_start(),
length,
V8InternalWriteBarrierMode::UPDATE_WRITE_BARRIER);
targetV8InternalShared->set_raw_scope_info(*targetScopeInfo);
#endif
targetV8InternalFunction.set_shared(targetV8InternalShared, V8InternalWriteBarrierMode::UPDATE_WRITE_BARRIER);
success = true;
Expand Down Expand Up @@ -223,13 +228,13 @@ JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionDisca
V8InternalSharedFunctionInfo::DiscardCompiled(v8InternalIsolate, v8::internal::handle(v8InternalShared, v8InternalIsolate));
return true;
}
}
}
}
return false;
}
}

JNIEXPORT jobjectArray JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetArguments
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
if (IS_V8_FUNCTION(v8ValueType)) {
auto v8InternalFunction = Javet::Converter::ToV8InternalJSFunction(v8LocalValue);
Expand Down Expand Up @@ -261,10 +266,10 @@ JNIEXPORT jobjectArray JNICALL Java_com_caoccao_javet_interop_V8Native_functionG
}
}
return nullptr;
}
}

JNIEXPORT jbyteArray JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetCachedData
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
if (IS_V8_FUNCTION(v8ValueType)) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
auto v8InternalFunction = Javet::Converter::ToV8InternalJSFunction(v8LocalValue);
Expand All @@ -288,13 +293,13 @@ JNIEXPORT jbyteArray JNICALL Java_com_caoccao_javet_interop_V8Native_functionGet
return Javet::Converter::ToJavaByteArray(jniEnv, cachedDataPointer.get());
}
}
}
}
}
return nullptr;
}

JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetContext
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
if (IS_V8_FUNCTION(v8ValueType)) {
auto v8InternalIsolate = reinterpret_cast<V8InternalIsolate*>(v8Context->GetIsolate());
Expand All @@ -307,7 +312,7 @@ JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetCon
}

JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetInternalProperties
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
if (IS_V8_FUNCTION(v8ValueType)) {
// This feature is not enabled yet.
Expand All @@ -328,7 +333,7 @@ JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetInt
}

JNIEXPORT jint JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetJSFunctionType
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
using namespace Javet::Enums::JSFunctionType;
if (IS_V8_FUNCTION(v8ValueType)) {
Expand All @@ -352,7 +357,7 @@ JNIEXPORT jint JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetJSFunc
}

JNIEXPORT jint JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetJSScopeType
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
if (IS_V8_FUNCTION(v8ValueType)) {
auto v8InternalFunction = Javet::Converter::ToV8InternalJSFunction(v8LocalValue);
Expand All @@ -369,7 +374,7 @@ JNIEXPORT jint JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetJSScop
}

JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetScopeInfos
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType,
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType,
jboolean includeGlobalVariables, jboolean includeScopeTypeGlobal) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
V8LocalArray v8LocalArray = v8::Array::New(v8Context->GetIsolate());
Expand Down Expand Up @@ -403,12 +408,12 @@ JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetSco
v8LocalArray->Set(v8Context, index, innerV8LocalArray).ToChecked();
++index;
}
}
}
return v8Runtime->SafeToExternalV8Value(jniEnv, v8Context, v8LocalArray);
}

JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetScriptSource
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
if (IS_V8_FUNCTION(v8ValueType)) {
V8InternalDisallowGarbageCollection disallowGarbageCollection;
Expand Down Expand Up @@ -440,13 +445,13 @@ JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetScr
Javet::Converter::ToJavaString(jniEnv, sourceCode.get()),
startPosition,
endPosition);
}
}
}
}
return nullptr;
}

JNIEXPORT jstring JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetSourceCode
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
if (IS_V8_FUNCTION(v8ValueType)) {
auto v8InternalFunction = Javet::Converter::ToV8InternalJSFunction(v8LocalValue);
Expand All @@ -470,13 +475,13 @@ JNIEXPORT jstring JNICALL Java_com_caoccao_javet_interop_V8Native_functionGetSou
startPosition, endPosition - startPosition);
#endif
return Javet::Converter::ToJavaString(jniEnv, sourceCode.get());
}
}
}
return nullptr;
}

JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionIsCompiled
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
if (IS_V8_FUNCTION(v8ValueType)) {
auto v8InternalFunction = Javet::Converter::ToV8InternalJSFunction(v8LocalValue);
Expand All @@ -493,7 +498,7 @@ JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionIsCom
}

JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionIsWrapped
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
if (IS_V8_FUNCTION(v8ValueType)) {
auto v8InternalFunction = Javet::Converter::ToV8InternalJSFunction(v8LocalValue);
Expand All @@ -510,7 +515,7 @@ JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionIsWra
}

JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionSetContext
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType, jobject mV8ContextValue) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType, jobject mV8ContextValue) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
jboolean success = false;
if (IS_V8_FUNCTION(v8ValueType)) {
Expand All @@ -525,7 +530,7 @@ JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionSetCo
}

JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionSetScriptSource
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType, jobject mScriptSource, jboolean mCloneScript) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType, jobject mScriptSource, jboolean mCloneScript) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
jboolean success = false;
if (IS_V8_FUNCTION(v8ValueType)) {
Expand Down Expand Up @@ -600,13 +605,13 @@ JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionSetSc
}
DELETE_LOCAL_REF(jniEnv, mSourceCode);
}
}
}
}
return success;
}

JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionSetSourceCode
(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType, jstring mSourceCode, jboolean mCloneScript) {
(JNIEnv * jniEnv, jobject caller, jlong v8RuntimeHandle, jlong v8ValueHandle, jint v8ValueType, jstring mSourceCode, jboolean mCloneScript) {
RUNTIME_AND_VALUE_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle, v8ValueHandle);
jboolean success = false;
if (IS_V8_FUNCTION(v8ValueType)) {
Expand Down Expand Up @@ -755,8 +760,8 @@ JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_functionSetSo
success = true;
}
break;
}
}
}
}
return success;
}
2 changes: 1 addition & 1 deletion docker/android/base.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

# Usage: docker build -t sjtucaocao/javet-android:3.1.8 -f docker/android/base.Dockerfile .

ARG JAVET_V8_VERSION=12.8.374.17
ARG JAVET_V8_VERSION=12.9.202.18

FROM ubuntu:20.04
WORKDIR /
Expand Down
2 changes: 1 addition & 1 deletion docker/linux-arm64/base_all_in_one.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# Usage: docker build -t sjtucaocao/javet-arm64:3.1.8 -f docker/linux-arm64/base_all_in_one.Dockerfile .

ARG JAVET_NODE_VERSION=18.15.0
ARG JAVET_V8_VERSION=12.8.374.17
ARG JAVET_V8_VERSION=12.9.202.18

FROM ubuntu:20.04
WORKDIR /
Expand Down
6 changes: 3 additions & 3 deletions docker/linux-arm64/base_v8.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
# limitations under the License.

# Usage: docker build \
# -t sjtucaocao/javet:arm64-base-v8_12.8.374.17 \
# -t sjtucaocao/javet:arm64-base-v8_12.9.202.18 \
# --build-arg JAVET_REPO=sjtucaocao/javet \
# --build-arg JAVET_V8_VERSION=12.8.374.17 \
# --build-arg JAVET_V8_VERSION=12.9.202.18 \
# -f docker/linux-arm64/base_v8.Dockerfile .

ARG JAVET_REPO=sjtucaocao/javet
ARG JAVET_V8_VERSION=12.8.374.17
ARG JAVET_V8_VERSION=12.9.202.18

FROM ${JAVET_REPO}:arm64-base-jvm

Expand Down
2 changes: 1 addition & 1 deletion docker/linux-x86_64/base_all_in_one.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ FROM ubuntu:20.04
WORKDIR /

ARG JAVET_NODE_VERSION=20.17.0
ARG JAVET_V8_VERSION=12.8.374.17
ARG JAVET_V8_VERSION=12.9.202.18

# Update Ubuntu
ENV DEBIAN_FRONTEND=noninteractive
Expand Down
6 changes: 3 additions & 3 deletions docker/linux-x86_64/base_v8.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
# limitations under the License.

# Usage: docker build \
# -t sjtucaocao/javet:x86_64-base-v8_12.8.374.17 \
# -t sjtucaocao/javet:x86_64-base-v8_12.9.202.18 \
# --build-arg JAVET_REPO=sjtucaocao/javet \
# --build-arg JAVET_V8_VERSION=12.8.374.17 \
# --build-arg JAVET_V8_VERSION=12.9.202.18 \
# -f docker/linux-x86_64/base_v8.Dockerfile .

ARG JAVET_REPO=sjtucaocao/javet
ARG JAVET_V8_VERSION=12.8.374.17
ARG JAVET_V8_VERSION=12.9.202.18

FROM ${JAVET_REPO}:x86_64-base-jvm

Expand Down
2 changes: 1 addition & 1 deletion docker/linux-x86_64/build.env
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
JAVET_REPO=sjtucaocao/javet
JAVET_VERSION=3.1.8
JAVET_V8_VERSION=12.8.374.17
JAVET_V8_VERSION=12.9.202.18
JAVET_NODE_VERSION=20.17.0
2 changes: 1 addition & 1 deletion docker/windows-x86_64/base.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
# Usage: docker build -t sjtucaocao/javet-windows:3.1.8 -m 4G -f docker/windows-x86_64/base.Dockerfile .

ARG JAVET_NODE_VERSION=20.17.0
ARG JAVET_V8_VERSION=12.8.374.17
ARG JAVET_V8_VERSION=12.9.202.18

# https://hub.docker.com/_/microsoft-windows
FROM mcr.microsoft.com/windows:20H2-amd64
Expand Down
6 changes: 6 additions & 0 deletions docs/release_notes/release_notes_3_1.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
Release Notes 3.1.x
===================

3.1.8
-----

* Upgraded V8 to ``v12.9.202.18`` (2024-09-13)
* Upgraded Visual Studio 2022 to `v17.11.3 <https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-notes-v17.11>`_

3.1.7
-----

Expand Down
2 changes: 1 addition & 1 deletion scripts/python/change_node_v8_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def update(self) -> None:
def main():
change_node_version = ChangeNodeVersion('20.17.0')
change_node_version.update()
change_v8_version = ChangeV8Version('12.8.374.17')
change_v8_version = ChangeV8Version('12.9.202.18')
change_v8_version.update()
return 0

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/caoccao/javet/enums/JSRuntimeType.java
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public enum JSRuntimeType {
*/
V8(
"v8",
"12.8.374.17",
"12.9.202.18",
V8RuntimeOptions::new,
o -> o instanceof V8RuntimeOptions);

Expand Down

0 comments on commit 782d4ea

Please sign in to comment.