🦄 refactor: Removed V8Runtime.hasScheduledException() and V8Runtime.p…

…romoteScheduledException()
caoccao · Oct 1, 2024 · 4bf7dd1 · 4bf7dd1
1 parent 1b69d57
commit 4bf7dd1
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 62 deletions.
diff --git a/cpp/jni/com_caoccao_javet_interop_V8Native.h b/cpp/jni/com_caoccao_javet_interop_V8Native.h
diff --git a/cpp/jni/javet_jni_error.cpp b/cpp/jni/javet_jni_error.cpp
@@ -49,16 +49,6 @@ JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_hasPendingMes
     return v8InternalIsolate->has_pending_message();
 }
 
-JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_hasScheduledException
-(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle) {
-    return false;
-}
-
-JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_promoteScheduledException
-(JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle) {
-    return false;
-}
-
 JNIEXPORT jboolean JNICALL Java_com_caoccao_javet_interop_V8Native_reportPendingMessages
 (JNIEnv* jniEnv, jobject caller, jlong v8RuntimeHandle) {
     RUNTIME_HANDLES_TO_OBJECTS_WITH_SCOPE(v8RuntimeHandle);

diff --git a/docs/release_notes/release_notes_4_0.rst b/docs/release_notes/release_notes_4_0.rst
@@ -7,3 +7,4 @@ Release Notes 4.0.x
 
 * Upgraded Node.js to ``v22.9.0`` `(2024-09-17) <https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.9.0>`_
 * Renamed ``V8Runtime.hasPendingException()`` to ``V8Runtime.hasException()``
+* Removed ``V8Runtime.hasScheduledException()`` and ``V8Runtime.promoteScheduledException()``
diff --git a/src/main/java/com/caoccao/javet/interop/IV8Native.java b/src/main/java/com/caoccao/javet/interop/IV8Native.java
@@ -150,8 +150,6 @@ boolean functionSetSourceCode(
 
     boolean hasPendingMessage(long v8RuntimeHandle);
 
-    boolean hasScheduledException(long v8RuntimeHandle);
-
     Object integerObjectCreate(long v8RuntimeHandle, int intValue);
 
     Object integerObjectValueOf(long v8RuntimeHandle, long v8ValueHandle, int v8ValueType);
@@ -338,8 +336,6 @@ Object promiseThen(
             long v8RuntimeHandle, long v8ValueHandle, int v8ValueType,
             long v8ValueFunctionFulfilledHandle, long v8ValueFunctionRejectedHandle);
 
-    boolean promoteScheduledException(long v8RuntimeHandle);
-
     Object proxyCreate(long v8RuntimeHandle, Object target);
 
     Object proxyGetHandler(long v8RuntimeHandle, long v8ValueHandle, int v8ValueType);

diff --git a/src/main/java/com/caoccao/javet/interop/V8Native.java b/src/main/java/com/caoccao/javet/interop/V8Native.java
@@ -215,9 +215,6 @@ public native boolean functionSetSourceCode(
     @Override
     public native boolean hasPendingMessage(long v8RuntimeHandle);
 
-    @Override
-    public native boolean hasScheduledException(long v8RuntimeHandle);
-
     @Override
     public native Object integerObjectCreate(long v8RuntimeHandle, int intValue);
 
@@ -516,9 +513,6 @@ public native Object promiseThen(
             long v8RuntimeHandle, long v8ValueHandle, int v8ValueType,
             long v8ValueFunctionFulfilledHandle, long v8ValueFunctionRejectedHandle);
 
-    @Override
-    public native boolean promoteScheduledException(long v8RuntimeHandle);
-
     @Override
     public native Object proxyCreate(long v8RuntimeHandle, Object target);
 

diff --git a/src/main/java/com/caoccao/javet/interop/V8Runtime.java b/src/main/java/com/caoccao/javet/interop/V8Runtime.java
@@ -1756,18 +1756,6 @@ public boolean hasPendingMessage() throws JavetException {
         return v8Native.hasPendingMessage(handle);
     }
 
-    /**
-     * Has scheduled exception.
-     *
-     * @return true : yes, false : no
-     * @throws JavetException the javet exception
-     * @since 1.0.4
-     */
-    @SuppressWarnings("RedundantThrows")
-    public boolean hasScheduledException() throws JavetException {
-        return v8Native.hasScheduledException(handle);
-    }
-
     /**
      * Initialize V8 value cache.
      *
@@ -3044,18 +3032,6 @@ <T extends V8ValuePromise> T promiseThen(
                 functionRejectedHandle == null ? 0L : functionRejectedHandle.getHandle());
     }
 
-    /**
-     * Promote scheduled exception.
-     *
-     * @return true : success, false : failure
-     * @throws JavetException the javet exception
-     * @since 1.0.4
-     */
-    @SuppressWarnings("RedundantThrows")
-    public boolean promoteScheduledException() throws JavetException {
-        return v8Native.promoteScheduledException(handle);
-    }
-
     /**
      * Gets a handler from a proxy
      *

diff --git a/src/test/java/com/caoccao/javet/interop/TestV8Runtime.java b/src/test/java/com/caoccao/javet/interop/TestV8Runtime.java
@@ -164,8 +164,6 @@ public void testPending() throws JavetException {
         try (V8Runtime v8Runtime = v8Host.createV8Runtime()) {
             assertFalse(v8Runtime.hasException());
             assertFalse(v8Runtime.hasPendingMessage());
-            assertFalse(v8Runtime.hasScheduledException());
-            assertFalse(v8Runtime.promoteScheduledException());
             assertFalse(v8Runtime.reportPendingMessages());
         }
     }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,3 +7,4 @@ Release Notes 4.0.x

		* Upgraded Node.js to ``v22.9.0`` `(2024-09-17) <https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.9.0>`_
		* Renamed ``V8Runtime.hasPendingException()`` to ``V8Runtime.hasException()``
		* Removed ``V8Runtime.hasScheduledException()`` and ``V8Runtime.promoteScheduledException()``