Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISD-2543 - Update README #246

Merged
merged 9 commits into from
Dec 4, 2024
Merged

ISD-2543 - Update README #246

merged 9 commits into from
Dec 4, 2024

Conversation

swetha1654
Copy link
Contributor

@swetha1654 swetha1654 commented Nov 27, 2024

Overview

Update the charm’s README on GitHub to follow the template outlined in is-charms-template-repo.

Checklist

@swetha1654 swetha1654 added documentation Improvements or additions to documentation trivial This is a trivial PR labels Nov 27, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@swetha1654 swetha1654 requested a review from erinecon November 28, 2024 16:43
@swetha1654 swetha1654 marked this pull request as ready for review November 28, 2024 16:43
@swetha1654 swetha1654 requested a review from a team as a code owner November 28, 2024 16:43
erinecon
erinecon previously approved these changes Nov 28, 2024
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README! It looks good to me 👍

Copy link
Contributor

@alithethird alithethird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 comment

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jdkandersson jdkandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since Erin approved before

Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, LGTM!

.trivyignore Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Test coverage for b3c663e

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          557     35    174     34    91%   162, 204-207, 299->302, 414, 473->477, 627, 658, 664, 681-685, 715, 750-751, 811, 820, 924->937, 936, 938, 943-944, 1004, 1024, 1031, 1121, 1130, 1142, 1163, 1172, 1191, 1195, 1224, 1265, 1397, 1419, 1426->1428, 1471->exit, 1483, 1493, 1531
src/cos.py             20      0      0      0   100%
src/exceptions.py      16      1      2      1    89%   41
src/state.py           33      0      2      0   100%
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 641     36    178     35    91%

Static code analysis report

Run started:2024-12-04 09:00:37.087125

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4647
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@swetha1654 swetha1654 merged commit 7b93a33 into main Dec 4, 2024
32 checks passed
@swetha1654 swetha1654 deleted the ISD-2543-readme branch December 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Libraries: Out of sync trivial This is a trivial PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants