Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests and docs for testing. #215

Merged
merged 6 commits into from
May 7, 2024
Merged

Conversation

javierdelapuente
Copy link
Contributor

@javierdelapuente javierdelapuente commented May 6, 2024

Applicable spec:

Overview

Updates to documentation. Docker -> rockcraft.

Also fixes to integration tests (change mysql version and a strip that was failing me locally).

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

weiiwang01
weiiwang01 previously approved these changes May 7, 2024
arturo-seijas
arturo-seijas previously approved these changes May 7, 2024
@javierdelapuente javierdelapuente dismissed stale reviews from arturo-seijas and weiiwang01 via 71521cb May 7, 2024 11:36
@canonical canonical deleted a comment from github-actions bot May 7, 2024
@javierdelapuente javierdelapuente changed the title Small updates to the documentation Fix integration tests -- fix docs. May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

Test coverage for 4ce7844

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          540     35    184     33    91%   162, 203-206, 370, 429->433, 582, 613, 619, 636-640, 670, 705-706, 764, 773, 877->890, 889, 891, 896-897, 957, 977, 984, 1074, 1083, 1095, 1116, 1125, 1144, 1148, 1177, 1230, 1362, 1384, 1391->1393, 1436->exit, 1448, 1458, 1496
src/cos.py             21      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/state.py           34      0      4      0   100%
src/types_.py          16      0      0      0   100%
---------------------------------------------------------------
TOTAL                 628     36    190     34    91%

Static code analysis report

Run started:2024-05-07 11:47:47.066637

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4584
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@javierdelapuente javierdelapuente added the trivial This is a trivial PR label May 7, 2024
@javierdelapuente javierdelapuente changed the title Fix integration tests -- fix docs. Fix integration tests and docs for testing. May 7, 2024
Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@javierdelapuente javierdelapuente merged commit 83b3df5 into main May 7, 2024
32 checks passed
@javierdelapuente javierdelapuente deleted the fix-docs branch May 7, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants