-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve WordPress's observability and increase health check timeout #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiiwang01
changed the title
[WIP] Enhance the observability of WordPress and increase health check timeout
Improve WordPress's observability and increase health check timeout
Feb 28, 2024
arturo-seijas
previously approved these changes
Feb 29, 2024
mthaddon
reviewed
Mar 4, 2024
Test coverage for 8d18b90
Static code analysis report
|
mthaddon
approved these changes
Mar 5, 2024
arturo-seijas
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve WordPress's observability by updating the Apache access log format to a structured format, including the sub-millisecond request times and durations in the access log. Introduce a new metric,
apache_access_log_request_duration_microseconds
, a histogram tracking request durations. Unlike metrics available through Apache'smod_status
, this specific metric is derived from Promtail reading the access log, which means it will only be available whenlogging
integration is established. This approach should offer better performance compared to usinglogql
.Update the dashboard with a new panel to visualizes request duration percentiles, providing better insights into WordPress performance issues.
Some other miscellaneous changes include adjusting the WordPress health check timeout from 3 to 5 seconds and upgrading WordPress to patch version
6.4.3
.