Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update wordpress version in rock to 6.4.1 #156

Merged
merged 11 commits into from
Nov 17, 2023
Merged

update wordpress version in rock to 6.4.1 #156

merged 11 commits into from
Nov 17, 2023

Conversation

Thanhphan1147
Copy link
Contributor

@Thanhphan1147 Thanhphan1147 commented Oct 26, 2023 •
edited
Loading

Update wordpress's major version from 5.x to 6.x (6.4.1)

  • Yoatseo can now be pulled in as latest stable
  • default 2023 and 2024 theme breaks integration tests on 6.4.1. Moved 2023 to manual installation and removed 2024 temporary.

Follow up PR would be needed to rework integration tests to be compatible with the 2024 theme

Checklist

@Thanhphan1147 Thanhphan1147 marked this pull request as ready for review October 26, 2023 19:01
@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner October 26, 2023 19:01
arturo-seijas
arturo-seijas previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanksyoon
yanksyoon previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, I believe the plugins are compatible with the major version upgrade?

@Thanhphan1147
Copy link
Contributor Author

Thanhphan1147 commented Nov 9, 2023 •
edited
Loading

yes, I made some changes to themes and plugins with this version upgrade, but nothing too major.

However, it seems that someone mentioned 6.2.3 might not be secure and we should use 6.4+

@Thanhphan1147 Thanhphan1147 changed the title update wordpress version in rock to 6.2.3 update wordpress version in rock to 6.4.1 Nov 10, 2023
@Thanhphan1147
Copy link
Contributor Author

Blindly updating version to see if integration tests pass.

amandahla
amandahla previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanksyoon
yanksyoon previously approved these changes Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Thanhphan1147 Thanhphan1147 dismissed stale reviews from yanksyoon and amandahla via d6f655e November 16, 2023 13:44
@github-actions GitHub Actions
Copy link
Contributor

Test coverage for 29e8baa

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          530     41    172     31    89%   190-193, 357-358, 559, 590, 596, 641, 676-677, 728-735, 740, 842->847, 846, 848, 853-854, 914, 932, 939, 1029, 1038, 1050, 1071, 1080, 1099, 1103, 1132, 1185, 1317, 1339, 1346->1348, 1391->exit, 1403, 1419, 1456, 1465-1466
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/types_.py          16      0      0      0   100%
---------------------------------------------------------------
TOTAL                 578     42    174     32    90%

Static code analysis report

Run started:2023-11-17 08:31:08.513843

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4298
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

arturo-seijas
arturo-seijas approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thanhphan1147 Thanhphan1147 merged commit a7f62fe into main Nov 17, 2023
36 checks passed
@Thanhphan1147 Thanhphan1147 deleted the ISD-1248/update_wordpress_version branch November 17, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturo-seijas arturo-seijas arturo-seijas approved these changes

@yanksyoon yanksyoon yanksyoon approved these changes

@amandahla amandahla Awaiting requested review from amandahla

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thanhphan1147 @amandahla @yanksyoon @arturo-seijas