-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove integration-test-with-secrets and run those tests in integration-test #151
remove integration-test-with-secrets and run those tests in integration-test #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f3506ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test coverage for 0e1aaee
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
Currently we are not using operator-workflows for tests that requires secrets even though support for this has been added. We should remove the integration-tests-with-secrets job by leveraging Add secret arguments to integration tests by yhaliaw · Pull Request #176 · canonical/operator-workflows.
To do this we’d need to define the INTEGRATION_TEST_ARGS secret and remove the -m "not (requires_secret)" arg in the integration-tests job. Example:Refactor integration test wfs by arturo-seijas · Pull Request #316 · canonical/indico-operator
Checklist
src-docs
urgent
,trivial
,complex
)