Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove integration-test-with-secrets and run those tests in integration-test #151

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

Thanhphan1147
Copy link
Contributor

@Thanhphan1147 Thanhphan1147 commented Oct 20, 2023

Overview

Currently we are not using operator-workflows for tests that requires secrets even though support for this has been added. We should remove the integration-tests-with-secrets job by leveraging Add secret arguments to integration tests by yhaliaw · Pull Request #176 · canonical/operator-workflows.

To do this we’d need to define the INTEGRATION_TEST_ARGS secret and remove the -m "not (requires_secret)" arg in the integration-tests job. Example:Refactor integration test wfs by arturo-seijas · Pull Request #316 · canonical/indico-operator

Checklist

Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nrobinaubertin
nrobinaubertin previously approved these changes Oct 20, 2023
arturo-seijas
arturo-seijas previously approved these changes Oct 23, 2023
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturo-seijas arturo-seijas dismissed stale reviews from nrobinaubertin and themself via f3506ba October 23, 2023 09:56
amandahla
amandahla previously approved these changes Oct 23, 2023
Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Test coverage for 0e1aaee

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          521     37    168     29    90%   197-200, 551, 582, 628, 663-664, 715-722, 727, 829->834, 833, 835, 840-841, 901, 919, 926, 1018, 1027, 1039, 1060, 1069, 1088, 1092, 1121, 1174, 1306, 1328, 1335->1337, 1380->exit, 1392, 1424, 1433-1434
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 568     38    170     30    90%

Static code analysis report

Run started:2023-10-24 07:56:39.328817

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4250
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturo-seijas arturo-seijas merged commit 90803fb into main Oct 24, 2023
25 checks passed
@arturo-seijas arturo-seijas deleted the ISD-1196/update-integration-test-workflow branch October 24, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants