Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove start event handler #132

Merged
merged 6 commits into from
Oct 24, 2023
Merged

chore: remove start event handler #132

merged 6 commits into from
Oct 24, 2023

Conversation

yanksyoon
Copy link
Collaborator

Applicable spec: N/A

Overview

Remove start event handler.

Rationale

It doesn't quite do anything.

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@yanksyoon yanksyoon added the trivial This is a trivial PR label Sep 20, 2023
@yanksyoon yanksyoon changed the title [WIP] chore: remove start event handler chore: remove start event handler Sep 20, 2023
@yanksyoon yanksyoon marked this pull request as ready for review September 20, 2023 01:47
@yanksyoon yanksyoon requested a review from a team as a code owner September 20, 2023 01:47
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanksyoon
Copy link
Collaborator Author

This is on hold until the defers / start event deletion is safe to do.

@github-actions
Copy link
Contributor

Test coverage for 4301278

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          517     37    168     29    90%   188-191, 542, 573, 619, 654-655, 706-713, 718, 820->825, 824, 826, 831-832, 892, 910, 917, 1009, 1018, 1030, 1051, 1060, 1079, 1083, 1112, 1165, 1297, 1319, 1326->1328, 1371->exit, 1383, 1415, 1424-1425
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 564     38    170     30    90%

Static code analysis report

Run started:2023-10-24 10:08:54.585936

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4243
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit 7bcad6c into main Oct 24, 2023
25 checks passed
@arturo-seijas arturo-seijas deleted the fix/defers branch October 24, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants