Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s 1.30 updates #14097

Merged
merged 2 commits into from
Aug 1, 2024
Merged

K8s 1.30 updates #14097

merged 2 commits into from
Aug 1, 2024

Conversation

evilnick
Copy link
Contributor

Done

Added docs pages for K8s 1.30 update

This includes:

  • creating 1.30 pages (upgrading,components and release notes)
  • updating the supported versions page
  • updating the main release notes page
  • fix for the COS tutorial
  • fix for OpenStack integration

Note that the content of these pages has already been reviewed here - charmed-kubernetes/kubernetes-docs#849

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes

@webteam-app
Copy link

Copy link
Member

@immortalcodes immortalcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through the demo docs and everything seemed fine, very minor comments for code.
Would you have me pay special attention to any other aspect of this PR? If not rest seems good.
Thanks for the good work

templates/kubernetes/docs/1.30/components.md Show resolved Hide resolved
Comment on lines +121 to +122


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown treats multiple blank lines as one, do you think we can use a singe line here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same applies to all the files

@evilnick
Copy link
Contributor Author

evilnick commented Aug 1, 2024

Thanks for the review @immortalcodes , will take a look at the spacing in the templates for the next time 👍

@evilnick evilnick merged commit 19c5367 into canonical:main Aug 1, 2024
13 checks passed
@evilnick evilnick deleted the K8s-1.30-updates branch August 1, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants