Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tempest rock #27

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

chanchiwai-ray
Copy link

Implement tempest snap as a rock image for tempest-k8s operator

hemanthnakkina
hemanthnakkina previously approved these changes Jan 19, 2024
Copy link
Collaborator

@gboutry gboutry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rock seems okay, but have you tried coming up with a configuration for renovate using snapstore apis ? instead of having a cron job to rebuild the snap

I believe renovate can be configured using output from: https://api.snapcraft.io/v2/snaps/info/tempest?architecture=amd64 and custom rules

@chanchiwai-ray
Copy link
Author

Thanks for the review. We are going to convert it to draft for now, we need to do some testing with the tempest-k8s charm first.

@chanchiwai-ray chanchiwai-ray marked this pull request as draft January 19, 2024 14:58
Copy link

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me with the tempest-k8s charm. Just one comment about adding comments to document design decisions, but otherwise good to go.


parts:
snap-tempest:
plugin: python

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed in the syncup, would you mind adding an inline comment here to explain why the python plugin and python3-venv package are required?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@chanchiwai-ray
Copy link
Author

@hemanthnakkina @gboutry We removed the workflow for rebuilding rock image when snap-tempest is updated, just to make the scope smaller for this PR. I'll appreciate your review again.

Copy link
Collaborator

@gboutry gboutry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work!

@hemanthnakkina hemanthnakkina merged commit 9a0d420 into canonical:main Jan 23, 2024
2 checks passed
@chanchiwai-ray chanchiwai-ray deleted the tempest-rock branch January 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants