-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tempest rock #27
Add Tempest rock #27
Conversation
6fabd24
to
5ae6523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Rock seems okay, but have you tried coming up with a configuration for renovate using snapstore apis ? instead of having a cron job to rebuild the snap
I believe renovate can be configured using output from: https://api.snapcraft.io/v2/snaps/info/tempest?architecture=amd64 and custom rules
Thanks for the review. We are going to convert it to draft for now, we need to do some testing with the tempest-k8s charm first. |
5ae6523
to
395eaac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works for me with the tempest-k8s charm. Just one comment about adding comments to document design decisions, but otherwise good to go.
rocks/tempest/rockcraft.yaml
Outdated
|
||
parts: | ||
snap-tempest: | ||
plugin: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed in the syncup, would you mind adding an inline comment here to explain why the python plugin and python3-venv package are required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
395eaac
to
abb685f
Compare
@hemanthnakkina @gboutry We removed the workflow for rebuilding rock image when snap-tempest is updated, just to make the scope smaller for this PR. I'll appreciate your review again. |
abb685f
to
a14784e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work!
Implement tempest snap as a rock image for tempest-k8s operator