-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use chisme update_layer #46
base: main
Are you sure you want to change the base?
Conversation
@@ -2,3 +2,4 @@ build/ | |||
__pycache__ | |||
.idea | |||
.tox | |||
.coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's be careful with .*ignore
files, they might make the diff confusing. You'd want to add these files if you are changing something in the CI or in the structure of the repo. You can keep it here for now, let's avoid this in future PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted. I think this file is created from running unit test. I wanted to avoid committing it. It is not currently committed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agathanatasha, your implementation is fine, I don't have much to say about it, though I am thinking if these try/catch
blocks that we are repeating can live in another helper method (I know we are trying to move away from that), as it seems redundant. What are your thoughts on that?
ff5febd
to
e8dca5c
Compare
Not for now. I can't tell whether it would be reused more or less at this point in time. We can create a helper method in the future if it would be reused more. |
Update training-operator to use the
update_layer
function in chisme, updated tests to matchCI would fail until this pr is merged and published. Tested locally with
git+https://github.com/canonical/charmed-kubeflow-chisme@KF-605/update-layer-handler
inrequirements.txt
Related to #94