Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use chisme update_layer #46

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

agathanatasha
Copy link
Contributor

@agathanatasha agathanatasha commented Aug 29, 2022

Update training-operator to use the update_layer function in chisme, updated tests to match
CI would fail until this pr is merged and published. Tested locally with git+https://github.com/canonical/charmed-kubeflow-chisme@KF-605/update-layer-handler in requirements.txt

Related to #94

@agathanatasha agathanatasha requested a review from a team as a code owner August 29, 2022 17:35
src/charm.py Outdated Show resolved Hide resolved
@@ -2,3 +2,4 @@ build/
__pycache__
.idea
.tox
.coverage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be careful with .*ignore files, they might make the diff confusing. You'd want to add these files if you are changing something in the CI or in the structure of the repo. You can keep it here for now, let's avoid this in future PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted. I think this file is created from running unit test. I wanted to avoid committing it. It is not currently committed.

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agathanatasha, your implementation is fine, I don't have much to say about it, though I am thinking if these try/catch blocks that we are repeating can live in another helper method (I know we are trying to move away from that), as it seems redundant. What are your thoughts on that?

@agathanatasha
Copy link
Contributor Author

Thanks @agathanatasha, your implementation is fine, I don't have much to say about it, though I am thinking if these try/catch blocks that we are repeating can live in another helper method (I know we are trying to move away from that), as it seems redundant. What are your thoughts on that?

Not for now. I can't tell whether it would be reused more or less at this point in time. We can create a helper method in the future if it would be reused more.

@agathanatasha agathanatasha requested review from DnPlas and a team September 9, 2022 18:59
@i-chvets i-chvets added the enhancement New feature or request label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants