Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement V1 of certificate_transfer #407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saltiyazan
Copy link

Issue

The new version (V1) of the certificate_transfer_interface is incompatible of its V0 version. Applications that implement V1 of cert transfer won't be able to share their CAs with Traefik.

Solution

This change is to allow application the implement the V1 version of the interface to integrate with Traefik to provide their CAs that Traefik needs to trust.
Note: The solution might seem a bit hacky, I tried to follow the same solution with IngressPerAppV0 and IngressPerAppV1.

Context

Testing Instructions

  • Deploy Traefik from this branch
  • Deploy notary-k8s from this branch
  • Deploy self-signed-certificates
  • Integrate Notary and self-signed-certificates using the certificates interface
  • Integrate Notary and Traefik using the receive-ca-cert-v1 interface
  • Observe the CA file being created in the correct directory in the Traefik container
  • Remove the integration and observe the file being removed

Upgrade Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant