Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traefik_route library ID #404

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Fix traefik_route library ID #404

merged 3 commits into from
Sep 19, 2024

Conversation

michaeldmitry
Copy link
Contributor

@michaeldmitry michaeldmitry commented Sep 18, 2024

Issue

Previous PR tried to publish a new library traefik_k8s.v0.traefik_route, but using an ID for an existing library traefik_route_k8s.v0.traefik_route.

Solution

Retrieve unique ID for this new lib using charmcraft create-lib traefik_route

Context

#403

Copy link
Collaborator

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll also need to reset libpatch to 0 or 1 as it's effectively a new library

@michaeldmitry
Copy link
Contributor Author

you'll also need to reset libpatch to 0 or 1 as it's effectively a new library

I did that last PR! But it seems CI has overwritten it after the merge (auto lib update?)
Good catch!

@michaeldmitry michaeldmitry merged commit 7699d68 into main Sep 19, 2024
11 checks passed
@michaeldmitry michaeldmitry deleted the lib-update branch September 19, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants