basic auth support #394
Merged
basic auth support #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic auth support for traefik.
This is an all-or-nothing, single-user basic implementation. In the future we might choose to extend it supporting per-route auth, as well as multi-user support.
Testing Instructions
Deploy traefik from this branch and relate it over any ingress, ingress-per-unit or traefik-route relation to another charm.
Go to https://www.transip.nl/htpasswd/ and enter some testing username/password pair. Copy the output string.
juju config traefik basic_auth_user='<that string>'(make sure to escape any weird characters)
Now verify that you need to enter that user/password pair when trying to CURL or GET any urls proxied by traefik