[ONB-730] test: increase coverage by testing dynamic TLS config generation for TCP routes #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add to the unit tests coverage in the function
_update_dynamic_config_route
, for the cases where'tcp'
routes are passed in the Charm configurationIssue
The unit tests do not cover the case of dynamic TLS configuration generation for TCP routes.
Solution
In the mock configuration passed to the unit tests, add TCP routes as well as their expected TLS auto-generated configuration.