tests: wait 1m before retry to reduce flakiness #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalian98
force-pushed
the
fix-forward-auth-tests-flakiness
branch
from
be41b69
to
f087e24
Compare
natalian98
force-pushed
the
fix-forward-auth-tests-flakiness
branch
from
f087e24
to
181abb2
Compare
|
@natalian98 we'll delete this branch as it seems to be stale, or do you intend to drive it to completion? |
|
Yes, you can delete this branch. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The forward-auth integration tests are flaky due to latency in mounting the configmap as a volume inside the container.
Solution
The latency depends on kubelet's
syncFrequencyconfig (see more reference here). The default is 1m, so to reduce the tests flakiness we can wait 1m before retrying a request.Context
n/a
Testing Instructions
n/a
Upgrade Notes
tests: wait 1m before retry to reduce flakiness