-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subdomain certs #274
base: main
Are you sure you want to change the base?
Subdomain certs #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments, but I agree with the decision and chosen approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bcb7b77
to
5946e18
Compare
src/charm.py
Outdated
if self._routing_mode is _RoutingMode.path: | ||
return self.external_host | ||
else: # _RoutingMode.subdomain | ||
prefix = "somehow, from reldata" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PietroPasotti would you be able to help out obtaining the prefix using the new schema classes?
I imagine #269 may have an impact on this?
5946e18
to
4df5895
Compare
Issue
The TLS cert solution was designed with only path routing in mind.
With subdomain routing, traefik is unable to match a domain to a cert.
Solution
Fixes #244.
Context
Testing Instructions
Release Notes