Validate the availability of traefik container before updating CA cer… #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatici
requested review from
sed-i,
Abuelodelanada,
lucabello,
PietroPasotti,
dstathis and
simskij
as code owners
gatici
force-pushed
the
TELCO-820-Validate-if-container-is-up-before-updating-ca-certs
branch
from
0103dbe
to
8f1bc7e
Compare
gatici
force-pushed
the
TELCO-820-Validate-if-container-is-up-before-updating-ca-certs
branch
from
490bfe9
to
a200a53
Compare
PietroPasotti
approved these changes
Oct 10, 2023
sed-i
reviewed
Oct 10, 2023
Signed-off-by: gatici <[email protected]>
sed-i
approved these changes
Oct 11, 2023
|
Thanks @gatici for this important fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate the availability of traefik container before updating CA certs
Issue
While updating CA certificates when CertificateTransfer relation joined, traefik container many not be running yet. This causes ConnectionError like https://github.com/canonical/vault-k8s-operator/actions/runs/6430745831/job/17462295379?pr=53.
Solution
Availability of traefik container needs to be checked before trying to update CA certs
Context
The issue is appeared when Traefik is related with Vault-k8s using CertificateTransfer interface.
Testing Instructions
Run
tox -e integration.Release Notes
This PR aims to fix the bug: #265.
First #266 needs to be merged as it fixes some existing test problems in main branch. Otherwise, some tests are failing regardless of this PR.