generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added tracing #207
Merged
Merged
added tracing #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
requested review from
sed-i,
Abuelodelanada,
lucabello,
dstathis and
simskij
as code owners
July 25, 2023 15:52
sed-i
reviewed
Jul 25, 2023
lucabello
reviewed
Jul 26, 2023
sed-i
reviewed
Jul 26, 2023
sed-i
reviewed
Jul 27, 2023
in light of canonical/charm-relation-interfaces#92, I propose we merge this one as-is, an open a follow-up replacing provider with requirer |
lucabello
approved these changes
Jul 31, 2023
sed-i
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we to rebase this on top of the direction flipping PR?
* chore: update charm libraries (#198) Co-authored-by: Github Actions <[email protected]> * chore: update charm libraries (#208) Co-authored-by: Github Actions <[email protected]> * removed no-extra-fields req on ingress v2 (#212) * chore: update charm libraries (#210) Co-authored-by: Github Actions <[email protected]> * flipped --------- Co-authored-by: Noctua <[email protected]> Co-authored-by: Github Actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds charm tracing and tempo tracing integration from builtin traefik instrumentation