Refactor muxpi connector #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LiaoU3 can you also please check the changed to make sure I am not missing something crucial |
talhaHavadar
force-pushed
the
refactor-muxpi-connector
branch
from
79255ea
to
d54cfff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanted to refactor the existing code in muxpi to have room for Partner Engineering specific actions to be placed in the future. I also saw muxpi was lacking tests so I thought it would be nice to increase coverage a bit it is still low but better than before.
I tried to keep changes small didnt really divide functions to keep things similar to ease the review.
Documentation
No interface has been changed so no need for doc update it is just an internal refactoring. New tests are also added to increase the coverage and tests are written based on the old implementation to make sure no business logic change introduced.
Tests
Only run
toxI need help to test this in the field.