Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return artefact status from api #65

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Return artefact status from api #65

merged 3 commits into from
Dec 4, 2023

Conversation

omar-selo
Copy link
Collaborator

@omar-selo omar-selo commented Nov 28, 2023 •
edited by jira bot
Loading

Resolves RTW-113

Returns with Artefacts the artefact status

andrejvelichkovski
andrejvelichkovski previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes, but should we add another ArtefactStatus, of NOT_REVIEWED or we would use NULL in such cases?

andrejvelichkovski
andrejvelichkovski approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for adding the new Enum type!

@omar-selo omar-selo merged commit e112f70 into main Dec 4, 2023
5 checks passed
@omar-selo omar-selo deleted the return-artefact-status branch December 4, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrejvelichkovski andrejvelichkovski andrejvelichkovski approved these changes

@nadzyah nadzyah Awaiting requested review from nadzyah

@jocave jocave Awaiting requested review from jocave

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omar-selo @andrejvelichkovski