Seed data fix #32
Merged
Seed data fix #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omar-selo
commented
Jun 22, 2023
| @@ -97,10 +98,10 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| def seed_data(): | |||
| def seed_data(client: TestClient | requests.Session): | |||
There was a problem hiding this comment.
I really dislike adding TestClient type here. But didn't find a way around it other than using Any which is worse
nadzyah
reviewed
Jun 23, 2023
nadzyah
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like previous PRs broke
scripts/seed_data.pyas we changed the endpoint. Additionally, after adding a test toseed_datafunction and making it fail on none success status codes. I found an actual bug withget_or_createapproach as sometimes the properties that should be included in creation of model shouldn't be included in querying. E.g. if we try to create an artefact and it fails due to unique constraints, then there is already an artefact with the same name, version and source combo. But if we query for this artefact with a different stage than it is in, we wont find it.