-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View previous artefact versions #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejvelichkovski
previously approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, maybe just we can make the version:
heading the same size as the other headings, such as track
or store
, to make it more consistent.
omar-selo
force-pushed
the
fetch-single-artefact-on-artefact-page
branch
from
September 11, 2024 08:57
8e909d8
to
86886ea
Compare
omar-selo
force-pushed
the
view-previous-artefact-versions
branch
2 times, most recently
from
September 11, 2024 11:55
6f03f8f
to
10e5e50
Compare
Base automatically changed from
fetch-single-artefact-on-artefact-page
to
main
September 11, 2024 12:01
omar-selo
dismissed
andrejvelichkovski’s stale review
September 11, 2024 12:01
The base branch was changed.
omar-selo
force-pushed
the
view-previous-artefact-versions
branch
from
September 11, 2024 12:13
d3108da
to
319b4ec
Compare
andrejvelichkovski
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows users to view and navigate to different versions of the same artefact. This can be done in two ways:
a. by clicking on drop down next to artefact version and picking one (this drop down shows all versions past and future)
b. by clicking on a previous test result when looking at individual test results
Resolved issues
Resolves https://warthogs.atlassian.net/browse/RTW-342
Documentation
Web service API changes
Updated
GET /v1/test-results/{id}/test-results
endpoint to also include the artefact id not just the versionAdded
GET /v1/artefacts/{id}/versions
endpoint that returns all versions of a particular artefact id sorted descendingTests
Added automated back-end tests.
Manually tested front-end. See below videos:
Screencast.from.2024-09-10.12-20-40.webm
Screencast.from.2024-09-10.13-09-54.webm