Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View previous artefact versions #212

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Conversation

omar-selo
Copy link
Collaborator

Description

Allows users to view and navigate to different versions of the same artefact. This can be done in two ways:
a. by clicking on drop down next to artefact version and picking one (this drop down shows all versions past and future)
b. by clicking on a previous test result when looking at individual test results

Resolved issues

Resolves https://warthogs.atlassian.net/browse/RTW-342

Documentation

Web service API changes

Updated GET /v1/test-results/{id}/test-results endpoint to also include the artefact id not just the version
Added GET /v1/artefacts/{id}/versions endpoint that returns all versions of a particular artefact id sorted descending

Tests

Added automated back-end tests.

Manually tested front-end. See below videos:

Screencast.from.2024-09-10.12-20-40.webm
Screencast.from.2024-09-10.13-09-54.webm

Copy link
Contributor

@andrejvelichkovski andrejvelichkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, maybe just we can make the version: heading the same size as the other headings, such as track or store, to make it more consistent.

@omar-selo omar-selo force-pushed the fetch-single-artefact-on-artefact-page branch from 8e909d8 to 86886ea Compare September 11, 2024 08:57
@omar-selo omar-selo force-pushed the view-previous-artefact-versions branch 2 times, most recently from 6f03f8f to 10e5e50 Compare September 11, 2024 11:55
Base automatically changed from fetch-single-artefact-on-artefact-page to main September 11, 2024 12:01
@omar-selo omar-selo dismissed andrejvelichkovski’s stale review September 11, 2024 12:01

The base branch was changed.

@omar-selo omar-selo merged commit 95581e3 into main Sep 11, 2024
2 of 3 checks passed
@omar-selo omar-selo deleted the view-previous-artefact-versions branch September 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants