Fetch single artefact on artefact page #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejvelichkovski
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Thanks for working on this, but I noticed a small issue while reviewing this, it is that the ratio of completed artefact is not updating as you review environments. It is not a huge issue, but perhaps we can fix it.
Also I think we can clean up some code with this change, in the providers/family_artefacts as we have functions to update the artefact status there, and to update the ratio as well, which we probably want to move here.
|
Ah good point I completely forgot about the ratio of completed artefact being present in two different locations |
omar-selo
force-pushed
the
fetch-single-artefact-on-artefact-page
branch
from
8e909d8
to
86886ea
Compare
andrejvelichkovski
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes artefact page fetch single artefact based on id rather than fetching current arteracts. This is beneficial for the following reasons:
Resolved issues
First PR towards resolving https://warthogs.atlassian.net/browse/RTW-342
Documentation
Web service API changes
Tests
Tested manually locally. Also tested that updating an artefact's status then going back to dashboard page shows the updated status.