-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend charm integration test run bugfix #20
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n blocked status (more scenarios needed to actually relate the frontend to the backend).
…ger the integration tests with.
… action is required.
mz2
commented
Jun 7, 2023
@@ -4,7 +4,7 @@ on: | |||
branches: | |||
- main | |||
push: | |||
branches: ["main"] | |||
branches: ["main", "integration-test-fix"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that we actually keep this in there because I imagine this will not be the last case where we have to open a branch & PR to fix integration tests issues, and it's awkward having to add a rule each time (or to tag all the time).
…state where relation is not yet connected. Simplified the charm logic, no _stored state needed (fetching the hostname and port from the relation's application data bag).
nadzyah
reviewed
Jun 8, 2023
Let's try with the microk8s version and libpyjuju < 3.1 that seems to work for rout53-acme-operator where the integration test pipeline is pulled from
…rver into integration-test-fix
This has been superseded by #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the sole frontend charm integration test scenario.
pylibjuju
depending on juju 2.x vs 3.x). I migrated to a fork of thecharmed-kubernetes/actions-operator
with which I could install more recent versions of juju and microk8s, in strict confinement (Makes juju and microk8s classic confinement optional charmed-kubernetes/actions-operator#57)._stored
, API server hostname and port read from the relation's application data bag (see more at https://juju.is/docs/sdk/integration, in particular the section "Handling integration data from non-relation hooks").Note: user
https://github.com/canonical-hw-certbot
was added as a collaborator to the project, and the token set in secrets is theirs (with onlypackages:read
permission set).