Fix can't update environment issue without a URL

canonical · Sep 23, 2024 · c6333bb · c6333bb
1 parent 15a01a2
commit c6333bb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/frontend/lib/models/environment_issue.dart b/frontend/lib/models/environment_issue.dart
@@ -9,7 +9,7 @@ class EnvironmentIssue with _$EnvironmentIssue {
     required int id,
     @JsonKey(name: 'environment_name') required String environmentName,
     required String description,
-    required String? url,
+    required Uri? url,
     @JsonKey(name: 'is_confirmed') required bool isConfirmed,
   }) = _EnvironmentIssue;
 

diff --git a/frontend/lib/ui/artefact_page/environment_issues/environment_issue_form.dart b/frontend/lib/ui/artefact_page/environment_issues/environment_issue_form.dart
@@ -45,18 +45,20 @@ class _EnvironmentIssueUpdateForm extends ConsumerWidget {
   @override
   Widget build(BuildContext context, WidgetRef ref) {
     return _EnvironmentIssueForm(
-      initialUrl: issue.url ?? '',
+      initialUrl: issue.url?.toString() ?? '',
       initialDescription: issue.description,
       initialIsConfirmed: issue.isConfirmed,
       formSubtitle: 'On all environments with name: ${issue.environmentName}',
-      onSubmit: (url, description, isConfirmed) =>
-          ref.read(environmentsIssuesProvider.notifier).updateIssue(
-                issue.copyWith(
-                  url: url,
-                  description: description,
-                  isConfirmed: isConfirmed,
-                ),
+      onSubmit: (url, description, isConfirmed) {
+        final parsedUrl = Uri.tryParse(url);
+        ref.read(environmentsIssuesProvider.notifier).updateIssue(
+              issue.copyWith(
+                url: (parsedUrl?.isAbsolute == true) ? parsedUrl : null,
+                description: description,
+                isConfirmed: isConfirmed,
               ),
+            );
+      },
       onDelete: () => showDialog<bool>(
         context: context,
         builder: (_) => _DeleteEnvironmentIssueConfirmationDialog(

diff --git a/frontend/lib/ui/artefact_page/environment_issues/environment_issue_list_item.dart b/frontend/lib/ui/artefact_page/environment_issues/environment_issue_list_item.dart
@@ -39,7 +39,7 @@ class EnvironmentIssueListItem extends StatelessWidget {
           const SizedBox(width: Spacing.level4),
           if (issueUrl != null)
             InlineUrlText(
-              url: issueUrl,
+              url: issueUrl.toString(),
               urlText: 'URL',
               fontStyle: Theme.of(context).textTheme.bodyMedium,
             ),