Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS-5032: Use Temporal lib worker #9

Merged
merged 5 commits into from
Aug 9, 2023
Merged

CSS-5032: Use Temporal lib worker #9

merged 5 commits into from
Aug 9, 2023

Conversation

kelkawi-a
Copy link
Collaborator

@kelkawi-a kelkawi-a commented Aug 6, 2023 •
edited
Loading

  • Changed the Temporal worker to use the Temporal lib worker which now has a built-in Sentry interceptor. Added Sentry-specific config to the charm to be able to use it. This has been tested with some sample workflows. Sentry logs uncaught exceptions as well as when using logging.error.
  • Added restart action for the Temporal worker.

mertalpt
mertalpt reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@mertalpt mertalpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think I know Temporal enough to give a definitive review on this but I am tending towards LGTM. I am only commenting for now but if this drags on too long let me know and I will take another look.

src/resources/sentry_interceptor.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/resources/sentry_interceptor.py Outdated Show resolved Hide resolved
@gtato
Copy link

gtato commented Aug 7, 2023

did you actually test this with sentry?

gtato
gtato reviewed Aug 7, 2023
View reviewed changes
src/resources/worker.py Outdated Show resolved Hide resolved
@kelkawi-a
Copy link
Collaborator Author

did you actually test this with sentry?

Yes, uncaught exceptions are reported in Sentry as well as when logging.error is used.

@kelkawi-a kelkawi-a changed the title CSS-5032: Add Sentry interceptor CSS-5032: Use Temporal lib worker Aug 8, 2023
gtato
gtato approved these changes Aug 8, 2023
View reviewed changes
Copy link

@gtato gtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@kelkawi-a kelkawi-a merged commit 998b089 into main Aug 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtato gtato gtato approved these changes

@kian99 kian99 Awaiting requested review from kian99

@AmberCharitos AmberCharitos Awaiting requested review from AmberCharitos

@zorzigio zorzigio Awaiting requested review from zorzigio

@maabujayyab maabujayyab Awaiting requested review from maabujayyab

@mertalpt mertalpt Awaiting requested review from mertalpt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelkawi-a @gtato @mertalpt