Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-6912: Add workload container health check #14

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

kelkawi-a
Copy link
Collaborator

This PR addresses the following:

  • Adds a handler to reapply the pebble plan after a restart with the pebble-ready event to address this bug (See this PR for reference).
  • Adds a workload container health check using exec, which checks if the Temporal worker is running or not.

@kelkawi-a kelkawi-a changed the title Add workload container health check CSS-6912: Add workload container health check Jan 24, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 44 files.

Valid Invalid Ignored Fixed
0 28 16 0
Click to see the invalid file list
  • actions.yaml
  • charmcraft.yaml
  • config.yaml
  • metadata.yaml
  • pyproject.toml
  • resource_sample/pyproject.toml
  • resource_sample/resource_sample/activities/activity1.py
  • resource_sample/resource_sample/activities/activity2.py
  • resource_sample/resource_sample/common/messages.py
  • resource_sample/resource_sample/workflows/workflow1.py
  • resource_sample/resource_sample/workflows/workflow2.py
  • src/charm.py
  • src/literals.py
  • src/log.py
  • src/resources/check_status.py
  • src/resources/temporal_client/init.py
  • src/resources/temporal_client/activities.py
  • src/resources/temporal_client/workflows.py
  • src/resources/worker.py
  • src/state.py
  • tests/integration/conftest.py
  • tests/integration/helpers.py
  • tests/integration/test_charm.py
  • tests/integration/test_scaling.py
  • tests/integration/test_upgrades.py
  • tests/unit/init.py
  • tests/unit/test_charm.py
  • tox.ini

@kelkawi-a kelkawi-a force-pushed the css-6912-workload-status branch 2 times, most recently from 3bf23de to d749b0a Compare January 24, 2024 14:18
Copy link

@maabujayyab maabujayyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

src/resources/check_status.py Outdated Show resolved Hide resolved
Copy link

@AmberCharitos AmberCharitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelkawi-a kelkawi-a merged commit da04d68 into main Jan 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants