Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReceiverProtocols confusion #13

Merged
merged 22 commits into from
Jul 30, 2024
Merged

Fix ReceiverProtocols confusion #13

merged 22 commits into from
Jul 30, 2024

Conversation

michaeldmitry
Copy link
Contributor

Issue

This helps address issue ##8

@michaeldmitry michaeldmitry requested a review from a team as a code owner July 14, 2024 23:25
@michaeldmitry michaeldmitry marked this pull request as draft July 14, 2024 23:25
@michaeldmitry michaeldmitry marked this pull request as ready for review July 26, 2024 09:30
@mmkay
Copy link
Contributor

mmkay commented Jul 29, 2024

This one seems to contain the changes from #14 as well? Guessing once we merge #14 the diff will be easier to digest.

PietroPasotti
PietroPasotti requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very hard to review this PR. Focused on charm.py and tempo code for this round

scripts/tracegen.py Outdated Show resolved Hide resolved
scripts/tracegen.py Outdated Show resolved Hide resolved
scripts/tracegen.py Show resolved Hide resolved
src/nginx_config.py Outdated Show resolved Hide resolved
src/nginx_config.py Show resolved Hide resolved
src/tempo.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@michaeldmitry michaeldmitry merged commit b114df1 into main Jul 30, 2024
13 checks passed
@michaeldmitry michaeldmitry mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmkay mmkay mmkay left review comments

@PietroPasotti PietroPasotti PietroPasotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeldmitry @mmkay @PietroPasotti