Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

DPE-781 Run integration tests for passed lint/unit tests only #38

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

taurus-forever
Copy link
Contributor

Avoid a long-running integration test in case of failing gatekeeping tests. It will slightly increase the complete tests scope runtime but will save (a lot?) of electricity/money for Canonical as often new pull requests have some initial typos/issues to be polished.

Closes: https://warthogs.atlassian.net/browse/DPE-781

Avoid a long-running integration test in case of failing gatekeeping tests.
It will slightly increase the complete tests scope runtime
but will save (a lot?) of electricity/money for Canonical as often
new pull requests have some initial typos/issues to be polished.
@taurus-forever
Copy link
Contributor Author

hI @jnsgruk , is it possible to merge this? Tnx!

@jnsgruk jnsgruk merged commit 247e327 into canonical:main Dec 6, 2022
@jnsgruk
Copy link
Member

jnsgruk commented Dec 6, 2022

@taurus-forever - done, sorry for the delay! Note that I'm planning on deprecating this, as most of the changes are now represented in the charmcraft init template itself.

@taurus-forever
Copy link
Contributor Author

taurus-forever commented Dec 6, 2022

@taurus-forever - done, sorry for the delay! Note that I'm planning on deprecating this, as most of the changes are now represented in the charmcraft init template itself.

Oh... this is good to know... as I planned to push another PR: #41

It is to update templates/workflows in .github/ folder and
use it as a reference in all DPE repos.
Do we have a better repo for .github configs to sync?

As I can see charmcraft init doesn't generate any .github/* templates/workflows at all.
Will it be improved?

@taurus-forever taurus-forever deleted the fix/run_tests_order branch December 6, 2022 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants