-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): add badges #203
Conversation
4d93566
to
cc2e34e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the correct way is to fix that "line too long" linter failure when the doc line is a URL - I would almost expect the linter to be aware that you can't wrap URLs.
I was fighting that last week on a personal repo. These badges in craft-providers (here) used to work and outsmarted the Github does a bad job rendering RST and I found many comments to the same effect in Github's issue tracker. I wasn't able to find any way with |
Found this issue: pylint-dev/pylint#2178 Seems like sphinx does ignore long lines for URLs by default, but that fails here since the URL isn't at the start of the line. So either you have to format your badge RST to put the URL on its own line, or modify sphinx's https://pylint.pycqa.org/en/latest/user_guide/configuration/all-options.html#ignore-long-lines |
Here's one possible suggestion for handling the line-length issue (not sure if it'll actually work): put the URLs in a separate "urls.txt" file, |
Honestly I'm tempted to just get rid of the |
well the real final boss you have to convince here is @sergiusens |
@lengau FWIW I completely agree - hard line breaks are essential for code but don't make sense for docs. |
+1 on dropping line length linting for docs because the tooling isn't good enough right now:
|
Personally not a fan, in the sense that the whole point of these simple markup files is that you can read them without processing them and the presentation might require certain structure. That said, this should be a soft requirement, I do not care for the linters. If we remove it, let's remove it for all, not just docs. |
Line length issue will be fixed via #233 |
Is this passing now because of #221 ? |
@mr-cal lol I guess. Nice! |
Fixes #180
tox
?