tests: enable core24 plugin tests #5209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Issue raised: #5207 Signed-off-by: Sergio Schvezov <[email protected]>
- Remove the dotnet test for core24 from build and run - Move the dotnet plugin test to the plugin suite Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
bepri
approved these changes
Jan 17, 2025
|
@bepri I still need to move those other python tests! |
tigarmo
reviewed
Jan 17, 2025
tests/spread/core24-suites/plugins/colcon-msg-package/task.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
…read' into work/CRAFT-3138-core24-plugin-spread
These tests were broken because the prime directory wasn't being made in managed builds
bepri
force-pushed
the
work/CRAFT-3138-core24-plugin-spread
branch
from
85292f9 to
0c323b0
Compare
tigarmo
reviewed
Feb 25, 2025
There was a problem hiding this comment.
thanks! One thing that looks "unclean" on these tests in general is the existence of spread/plugins/v2 referring to core20, spread/plugins/craft-parts referring to core22 and spread/core24-suites/plugins for core24. Seems a bit too cryptic but I don't think we need to address that in this PR
tests/spread/core24-suites/plugins/build-and-run-hello/poetry-hello/snap/snapcraft.yaml
Show resolved
Hide resolved
tests/spread/core24-suites/plugins/python-hello/classic/snap/snapcraft.yaml
Outdated
Show resolved
Hide resolved
tigarmo
approved these changes
Feb 25, 2025
mr-cal
reviewed
Feb 25, 2025
lengau
approved these changes
Feb 26, 2025
The kernel plugin is only available as an experimental plugin, which isn't supported by snapcraft in core24, so this test isn't possible to run.
mr-cal
approved these changes
Feb 27, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)