feat: add Snapcraft-specific Poetry plugin #5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigarmo
force-pushed
the
work/CRAFT-3363-snapcraft-poetry
branch
from
6d056a6
to
afdcbce
Compare
The plugin has the same behavior and restrictions as the Python plugin with regards to base-dependent behavior, symlink handling, etc. Therefore, this common behavior is extracted into a new "python_common" module, used by both plugins. This approach is also taken for the reference docs - the requirement of staging a Python interpreter (or not) is the same for both plugins. Enabled for core22 and core24. Fixes #5025
tigarmo
force-pushed
the
work/CRAFT-3363-snapcraft-poetry
branch
from
afdcbce
to
8eb88cb
Compare
lengau
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin has the same behavior and restrictions as the Python plugin with regards to base-dependent behavior, symlink handling, etc.
Therefore, this common behavior is extracted into a new "python_common" module, used by both plugins. This approach is also taken for the reference docs - the requirement of staging a Python interpreter (or not) is the same for both plugins.
Enabled for core22 and core24.
Fixes #5025
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)