Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remote-build): parse --launchpad-timeout argument #4426

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 26, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Two changes:

  1. Fix a regression where --launchpad-timeout was not parsed and could not be used by the fallback remote builder.
  2. Add support for --launchpad-timeout in new remote builder

Note - I made 2 PRs (this one and #4427) because the remote build code is very different between main and the hotfix/7.5 branches (main has the new remote builder code, hotfix/7.5 does not).

Fixes #4397
(CRAFT-2094)

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Merging #4426 (ea85f98) into main (e3b8a3a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #4426      +/-   ##
==========================================
+ Coverage   89.18%   89.20%   +0.02%     
==========================================
  Files         322      322              
  Lines       21659    21663       +4     
==========================================
+ Hits        19316    19324       +8     
+ Misses       2343     2339       -4     
Files Coverage Δ
snapcraft/commands/remote.py 98.78% <100.00%> (+<0.01%) ⬆️
snapcraft/remote/errors.py 100.00% <100.00%> (ø)
snapcraft/remote/launchpad.py 89.06% <100.00%> (+1.66%) ⬆️
snapcraft/remote/remote_builder.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal requested a review from a team October 26, 2023 20:12
@mr-cal
Copy link
Collaborator Author

mr-cal commented Oct 26, 2023

Store spread test failure is unrelated (#4411)

@mr-cal mr-cal requested a review from a team October 27, 2023 14:48
@mr-cal mr-cal merged commit c6f41da into main Oct 28, 2023
9 of 10 checks passed
@mr-cal mr-cal deleted the remote-build-timeout-main branch October 28, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snapcraft remote-build --launchpad-timeout does not work
4 participants