fix(remote-build): warn instead of error when using unsupported bases #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
changed the title
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #4396 +/- ##
==========================================
- Coverage 89.13% 89.12% -0.01%
==========================================
Files 321 318 -3
Lines 21502 21181 -321
==========================================
- Hits 19165 18878 -287
+ Misses 2337 2303 -34
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmatsuoka
reviewed
Oct 6, 2023
| try: | ||
| base = self._get_effective_base() | ||
| except MaintenanceBase as base_err: | ||
| base = base_err.base |
There was a problem hiding this comment.
Interesting way to recover the base value.
cmatsuoka
approved these changes
Oct 6, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?Fixes #4357