-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remote-build): warn instead of error when using unsupported bases #4396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #4396 +/- ##
==========================================
- Coverage 89.13% 89.12% -0.01%
==========================================
Files 321 318 -3
Lines 21502 21181 -321
==========================================
- Hits 19165 18878 -287
+ Misses 2337 2303 -34
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
try: | ||
base = self._get_effective_base() | ||
except MaintenanceBase as base_err: | ||
base = base_err.base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting way to recover the base value.
make lint
?pytest tests/unit
?Fixes #4357