Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Fixes for Gnome Extension #4391

Closed
wants to merge 33 commits into from
Closed

Various Fixes for Gnome Extension #4391

Changes from 3 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
7544f82
added `GDK_DEBUG: portals` in environment
soumyaDghosh Oct 4, 2023
90c96ab
added layout for webkit2gtk-4.1 and changed all `SNAPCRAFT`s to `CRAFT`
soumyaDghosh Oct 4, 2023
99706fe
fixed typo
soumyaDghosh Oct 4, 2023
aaeb5b4
remove `GDK_DEBUG: portals` as unrelated and harmful
soumyaDghosh Oct 5, 2023
03407f2
fix: add part in snapcraft.yaml to build libgit2
sergiusens Oct 4, 2023
6c358a4
chore(remote-build): migrate LaunchpadClient and WorkTree (#4390)
mr-cal Oct 6, 2023
9bcc0c7
ci: disable python 3.8 testing
sergiusens Oct 6, 2023
cc25806
fix(remote-build): warn instead of error when using unsupported bases
sergiusens Oct 6, 2023
866c428
feat(remote-build): new command logic (#4395)
mr-cal Oct 6, 2023
8f8b866
chore: ignore types for pkg_resources (#4406)
mr-cal Oct 18, 2023
5165183
chore(deps): update craft-providers to 1.18.0 (#4409)
mr-cal Oct 19, 2023
6004639
feat(plugins): add core20 support for pyproject.toml projects (#4087)
brlin-tw Oct 19, 2023
93042a3
build(deps): bump urllib3 from 1.26.17 to 1.26.18 in /docs/.sphinx (#…
dependabot[bot] Oct 19, 2023
d0e3cf1
build(deps): bump urllib3 from 1.26.17 to 1.26.18 (#4404)
dependabot[bot] Oct 19, 2023
ba6ea95
chore: update Python version metadata (#4415)
lengau Oct 23, 2023
0548f4d
style: fix ruff format tox environment (#4416)
lengau Oct 23, 2023
9ec27cf
chore(deps): update ruff to 0.1.1 and fix lint issues (#4417)
lengau Oct 25, 2023
cd96dcd
chore(pyproject): quote versions (#4423)
mr-cal Oct 27, 2023
ed42603
fix(remote-build): parse `--launchpad-timeout` argument (#4426)
mr-cal Oct 28, 2023
facbcc6
chore: migrate dev environment to ubuntu 22.04 and python 3.10 (#4425)
mr-cal Oct 30, 2023
7d3c35a
docs(TESTING.md): update commands (#4428)
stephensp Oct 30, 2023
e3865d3
build(deps): bump craft-providers to 1.19.1 (#4421) (#4429)
syu-w Oct 31, 2023
71f3b05
fix(cli): catch remote-build errors
mr-cal Oct 27, 2023
1ffda79
fix(remote-build): improve logging
mr-cal Oct 31, 2023
1b83ee9
feat(linter): show missing libraries corresponding package
syu-w Oct 31, 2023
09965ed
tests(spread): add remote-build spread test
mr-cal Oct 31, 2023
142ba8d
chore(log): hide command in output when pack failed (#4434)
syu-w Nov 3, 2023
2f28be5
ci: colorize tox and collapse sections (#4435)
mr-cal Nov 3, 2023
32a27d6
build(deps): bump craft-providers to 1.19.2 (#4437)
mr-cal Nov 3, 2023
1217381
docs(architectures): remove shorthand notation for core22 architectur…
mr-cal Nov 7, 2023
6eba18e
feat: enable chisel (#4441)
sergiusens Nov 8, 2023
ca40ab0
feat: improve lifecycle messages (#4431)
sergiusens Nov 13, 2023
43e401c
chore(ci): publish snaps for feature/ branches (#4447)
tigarmo Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions snapcraft/extensions/gnome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class GNOME(Extension):
- GTK3 Themes.
- Common Icon Themes.
- Common Sound Themes.
- The GNOME runtime libraries and utilities corresponding to 3.38.
- The GNOME runtime libraries and utilities corresponding to versions from 3.38 to 45.

For easier desktop integration, it also configures each application
entry with these additional plugs:
Expand Down Expand Up @@ -147,6 +147,7 @@ def get_root_snippet(self) -> Dict[str, Any]:
"environment": {
"SNAP_DESKTOP_RUNTIME": "$SNAP/gnome-platform",
"GTK_USE_PORTAL": "1",
"GDK_DEBUG": "portals",
soumyaDghosh marked this conversation as resolved.
Show resolved Hide resolved
},
"hooks": {
"configure": {
Expand All @@ -155,8 +156,11 @@ def get_root_snippet(self) -> Dict[str, Any]:
}
},
"layout": {
"/usr/lib/$SNAPCRAFT_ARCH_TRIPLET/webkit2gtk-4.0": {
"bind": "$SNAP/gnome-platform/usr/lib/$SNAPCRAFT_ARCH_TRIPLET/webkit2gtk-4.0"
"/usr/lib/$CRAFT_ARCH_TRIPLET/webkit2gtk-4.0": {
"bind": "$SNAP/gnome-platform/usr/lib/$CRAFT_ARCH_TRIPLET/webkit2gtk-4.0"
},
"/usr/lib/$CRAFT_ARCH_TRIPLET/webkit2gtk-4.1": {
"bind": "$SNAP/gnome-platform/usr/lib/$CRAFT_ARCH_TRIPLET/webkit2gtk-4.1"
},
"/usr/share/xml/iso-codes": {
"bind": "$SNAP/gnome-platform/usr/share/xml/iso-codes"
Expand Down