manifest: correctly handle unspecified stage packages (#3828)

Stage packages in manifest used the values from the state assets and was populated with null when no stage packages were defined in the part. Fixed to use empty list in this case. Signed-off-by: Claudio Matsuoka <[email protected]>
canonical · Jul 6, 2022 · cd72857 · cd72857
1 parent 426beb5
commit cd72857
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/snapcraft/parts/lifecycle.py b/snapcraft/parts/lifecycle.py
@@ -301,7 +301,7 @@ def _generate_manifest(
     for name, part in parts.items():
         assets = lifecycle.get_part_pull_assets(part_name=name)
         if assets:
-            part["stage-packages"] = assets.get("stage-packages", [])
+            part["stage-packages"] = assets.get("stage-packages", []) or []
         for key in ("stage", "prime", "stage-packages", "build-packages"):
             part.setdefault(key, [])
 

diff --git a/tests/spread/core22/manifest/manifest-creation/snap/snapcraft.yaml b/tests/spread/core22/manifest/manifest-creation/snap/snapcraft.yaml
@@ -16,3 +16,5 @@ parts:
     plugin: nil
     stage-packages:
       - hello
+  other-part:
+    plugin: nil