chore: remove deprecated parameter build-base (#4505)

Signed-off-by: Callahan Kovacs <[email protected]>
canonical · Jan 5, 2024 · 4aa5f63 · 4aa5f63
1 parent 7bd0d3a
commit 4aa5f63
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/snapcraft/parts/lifecycle.py b/snapcraft/parts/lifecycle.py
@@ -565,7 +565,6 @@ def _run_in_provider(
         project_name=project.name,
         project_path=project_path,
         base_configuration=base_configuration,
-        build_base=build_base.value,
         instance_name=instance_name,
         allow_unstable=allow_unstable,
     ) as instance:

diff --git a/tests/unit/conftest.py b/tests/unit/conftest.py
@@ -354,7 +354,7 @@ def launched_environment(
             project_name: str,
             project_path: Path,
             base_configuration: Base,
-            build_base: str,
+            build_base: Optional[str] = None,
             instance_name: str,
             allow_unstable: bool = False,
         ):

diff --git a/tests/unit/parts/test_lifecycle.py b/tests/unit/parts/test_lifecycle.py
@@ -1226,7 +1226,6 @@ def test_lifecycle_run_in_provider_default(
         project_name="mytest",
         project_path=ANY,
         base_configuration=mock_base_configuration,
-        build_base="22.04",
         instance_name="test-instance-name",
         allow_unstable=False,
     )
@@ -1350,7 +1349,6 @@ def test_lifecycle_run_in_provider_all_options(
         project_name="mytest",
         project_path=ANY,
         base_configuration=mock_base_configuration,
-        build_base="22.04",
         instance_name="test-instance-name",
         allow_unstable=False,
     )
@@ -1452,7 +1450,6 @@ def test_lifecycle_run_in_provider(
         project_name="mytest",
         project_path=ANY,
         base_configuration=mock_base_configuration,
-        build_base=BuilddBaseAlias.JAMMY.value,
         instance_name="test-instance-name",
         allow_unstable=False,
     )