Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make lint-python use requirements versions #4519

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Lukewh
Copy link
Contributor

@Lukewh Lukewh commented Jan 31, 2024

Done

  • Ensure lint-python uses the versions of black and flake8 defined in requirements.txt

How to QA

  • The checks should pass for this PR

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4519.demos.haus

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d064be7) 68.43% compared to head (1a7f59e) 79.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4519       +/-   ##
===========================================
+ Coverage   68.43%   79.83%   +11.39%     
===========================================
  Files         112      206       +94     
  Lines        3583    10501     +6918     
  Branches      926      926               
===========================================
+ Hits         2452     8383     +5931     
- Misses       1007     1994      +987     
  Partials      124      124               
Flag Coverage Δ
javascript 68.43% <ø> (ø)
python 85.73% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lukewh Lukewh marked this pull request as ready for review January 31, 2024 10:23
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Lukewh Lukewh merged commit 8cd90eb into canonical:main Jan 31, 2024
10 checks passed
@Lukewh Lukewh deleted the python-lint branch January 31, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants