Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selected brandstore not persisting #4506

Merged
merged 14 commits into from
Jan 22, 2024
Merged

Fix selected brandstore not persisting #4506

merged 14 commits into from
Jan 22, 2024

Conversation

codeEmpress1
Copy link
Contributor

@codeEmpress1 codeEmpress1 commented Jan 18, 2024

Done

  • Fix selected brand store not persisting if an error occur when trying to register snap name

How to QA

  • Go to https://snapcraft-io-4506.demos.haus/register-snap
  • Select a brand store
  • Fill in snapd or any registered snap name into the snap name field
  • click on register, an error will be displayed
  • Ensure that the store displayed in the store field is the same store you selected earlier

Issue / Card https://warthogs.atlassian.net/browse/WD-8313

Fixes # #4392

Screenshots

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4506.demos.haus

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (901647f) 79.83% compared to head (e076005) 79.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4506      +/-   ##
==========================================
- Coverage   79.83%   79.83%   -0.01%     
==========================================
  Files         207      206       -1     
  Lines       10505    10501       -4     
  Branches      926      926              
==========================================
- Hits         8387     8383       -4     
  Misses       1994     1994              
  Partials      124      124              
Flag Coverage Δ
javascript 68.43% <ø> (ø)
python 85.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeEmpress1 codeEmpress1 changed the base branch from main to increase-timeout January 18, 2024 15:20
@codeEmpress1 codeEmpress1 changed the base branch from increase-timeout to main January 18, 2024 15:21
@codeEmpress1 codeEmpress1 changed the base branch from main to feature/bar-graphs January 18, 2024 15:21
@codeEmpress1 codeEmpress1 changed the base branch from feature/bar-graphs to main January 18, 2024 15:21
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codeEmpress1 codeEmpress1 merged commit dd4953e into canonical:main Jan 22, 2024
9 of 10 checks passed
@codeEmpress1 codeEmpress1 deleted the fix-selected-brandstore-not-persisting branch January 22, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants