Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal dependencies #4498

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Update internal dependencies #4498

merged 6 commits into from
Jan 22, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 4, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
canonicalwebteam.store-base ==0.4.1 -> ==0.5.0 age adoption passing confidence
vanilla-framework (source) 4.5.1 -> 4.6.0 age adoption passing confidence

Release Notes

canonical/vanilla-framework (vanilla-framework)

v4.6.0

Compare Source

Getting Vanilla Framework

Install with NPM: https://www.npmjs.com/package/vanilla-framework
Visit the documentation at https://vanillaframework.io/docs

New in Vanilla v4.6.0

🚀 Features
💣 Potentially breaking changes

With the introduction of new responsive grid patterns (row--25-75-on-medium, etc), the default responsive behaviour of row--25-75 has changed. Previously on medium screens it did not split the layout, but used a stacked mobile layout. With Vanilla 4.6.0 the row--25-75 will split into 2+4 columns layout on medium screens by default. This also means that is-split-on-medium modifier class is no longer needed, as its behaviour is now default for row--25-75.

If you are using row--25-75 without is-split-on-medium make sure that the layout doesn't break on medium screen sizes.
If you are using row--25-75 with is-split-on-medium no change is needed, but is-split-on-medium is redundant and can be safely removed from code.

For more information refer to the Vanilla grid documentation.

🐛 Bug Fixes
🔨 Maintenance

Full Changelog: canonical/vanilla-framework@v4.5.1...v4.6.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4498.demos.haus

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4f3b81) 79.83% compared to head (7306521) 85.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4498      +/-   ##
==========================================
+ Coverage   79.83%   85.73%   +5.89%     
==========================================
  Files         207       94     -113     
  Lines       10505     6918    -3587     
  Branches      926        0     -926     
==========================================
- Hits         8387     5931    -2456     
+ Misses       1994      987    -1007     
+ Partials      124        0     -124     
Flag Coverage Δ
javascript ?
python 85.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/internal branch from d7f1e70 to 49e7f84 Compare January 16, 2024 11:09
@renovate renovate bot changed the title Update dependency canonicalwebteam.store-base to v0.5.0 Update internal dependencies Jan 16, 2024
@bartaz
Copy link
Member

bartaz commented Jan 16, 2024

Due to changes in Vanilla 4.6.0 with row--25-75 home page featured section breaks on medium screens:

image

row--25-75-on-large should be used instead - or tabs need to be used on mobile screens only.

Copy link
Contributor Author

renovate bot commented Jan 16, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@bartaz
Copy link
Member

bartaz commented Jan 16, 2024

I pushed a commit that should fix the issue mentioned above.

@steverydz steverydz merged commit 901647f into main Jan 22, 2024
10 checks passed
@steverydz steverydz deleted the renovate/internal branch January 22, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants