Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle categories #4487

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Handle categories #4487

merged 1 commit into from
Jan 2, 2024

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Dec 13, 2023

Done

Handled the categories on the beta store page

How to QA

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4487.demos.haus

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c26d71b) 79.78% compared to head (73b032c) 68.43%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4487       +/-   ##
===========================================
- Coverage   79.78%   68.43%   -11.35%     
===========================================
  Files         207      112       -95     
  Lines       10476     3583     -6893     
  Branches      926      926               
===========================================
- Hits         8358     2452     -5906     
+ Misses       1994     1007      -987     
  Partials      124      124               
Flag Coverage Δ
javascript 68.43% <ø> (ø)
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steverydz steverydz changed the title WIP: Remove featured category Handle categories Dec 14, 2023
@steverydz steverydz marked this pull request as ready for review December 14, 2023 14:53
Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@steverydz steverydz merged commit 18dba8f into canonical:main Jan 2, 2024
9 of 10 checks passed
@steverydz steverydz deleted the beta-store-categories branch January 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants