Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings page error messages #4481

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

Lukewh
Copy link
Contributor

@Lukewh Lukewh commented Dec 12, 2023

Done

  • Updated settings page to work the same as listings page.
  • Make error messages a little more friendly on both
  • Drive-by: Updated eslintrc to remove linting warning

How to QA

  • Visit the settings page for a snap without a description and or summary
  • Try and update visibility
  • ERRORS 🥳
  • The changes made should not be reverted on the page

Issue / Card

Fixes #

Screenshots

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4481.demos.haus

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9088de) 68.41% compared to head (ebb00e1) 68.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4481   +/-   ##
=======================================
  Coverage   68.41%   68.41%           
=======================================
  Files         112      112           
  Lines        3581     3581           
  Branches      924      924           
=======================================
  Hits         2450     2450           
  Misses       1007     1007           
  Partials      124      124           
Flag Coverage Δ
javascript 68.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Lukewh Lukewh merged commit 4191cf6 into canonical:main Dec 12, 2023
10 checks passed
@Lukewh Lukewh deleted the settings-page-errors branch December 12, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants