Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing featured categories #4469

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Showing featured categories #4469

merged 1 commit into from
Dec 5, 2023

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Dec 5, 2023

Done

Removed all snaps and use featured snaps

How to QA

Issue / Card

Fixes:

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4469.demos.haus

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0801dd4) 79.80% compared to head (fca1090) 79.82%.

Files Patch % Lines
webapp/store/views.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4469      +/-   ##
==========================================
+ Coverage   79.80%   79.82%   +0.02%     
==========================================
  Files         207      207              
  Lines       10467    10463       -4     
  Branches      924      924              
==========================================
- Hits         8353     8352       -1     
+ Misses       1990     1987       -3     
  Partials      124      124              
Flag Coverage Δ
javascript 68.41% <ø> (ø)
python 85.75% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@steverydz steverydz merged commit a75da59 into canonical:main Dec 5, 2023
9 of 10 checks passed
@steverydz steverydz deleted the show-featured-category-in-beta-store branch December 5, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants