Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move model overview CTA and update title #4373

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Aug 8, 2023

Done

  • Moved the CTA on model overview to the top of the view
  • Added a breadcrumb navigation
  • Hide h1 except for screen readers

How to QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-5631

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4373.demos.haus

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4373 (a7823c6) into main (27e8b75) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a7823c6 differs from pull request most recent head bb13f16. Consider uploading reports for the commit bb13f16 to get more accurate results

@@           Coverage Diff           @@
##             main    #4373   +/-   ##
=======================================
  Coverage   80.32%   80.33%           
=======================================
  Files         205      206    +1     
  Lines       10273    10276    +3     
  Branches      901      901           
=======================================
+ Hits         8252     8255    +3     
  Misses       1899     1899           
  Partials      122      122           
Flag Coverage Δ
javascript 69.48% <100.00%> (+0.02%) ⬆️
python 85.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tatic/js/brand-store/components/Model/ModelNav.tsx 100.00% <ø> (ø)
...tatic/js/brand-store/components/Model/Policies.tsx 69.76% <ø> (ø)
...s/brand-store/components/SectionNav/SectionNav.tsx 100.00% <ø> (ø)
static/js/brand-store/components/Model/Model.tsx 49.15% <100.00%> (ø)
...s/brand-store/components/Model/ModelBreadcrumb.tsx 100.00% <100.00%> (ø)

@Lukewh
Copy link
Contributor

Lukewh commented Aug 8, 2023

For some reason I see a li dot in the nav:
image

And when you go to the policies tab you lose the breadcrumb:
image

@julpal7
Copy link

julpal7 commented Aug 8, 2023

@steverydz I agree with Luke on the breadcrumb (however, there is no dot in my preview). Secondly, could you please move the first text line up to align with the text on CTAs? Thanks in advance!

snapcraft-io-4373 demos haus_admin_njwQYXFnS7ppo7LaGxoh7aqVZc1CPi26_models_aliomt-test-model-no-api-key1

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@julpal7
Copy link

julpal7 commented Aug 9, 2023

Everything looks good, thanks Steve

@steverydz steverydz merged commit 7ad3630 into canonical:main Aug 9, 2023
8 checks passed
@steverydz steverydz deleted the move-model-overview-cta branch August 9, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants